This repository has been archived by the owner on May 2, 2024. It is now read-only.
Added shutdown_hook_priority to rabbitmq_server #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@stijnjanmaat welcome to WP Minions and thanks for the feedback and PR. Some of our team is traveling for conferences and vacations right now but I'll get this to them when they're back and let you know if there are any questions/concerns from their review. Thanks again! |
|
Hi @jeffpaul, did you get a chance to look at this request? |
|
@stijnjanmaat not as of yet, no, but with WP 5.4 coming next week we're working in parallel to test compatibility there so expect some closer review of this PR in the near future. I appreciate your patience, thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
When you have multiple actions taking place on the wp hook shutdown, you want to be able to postpone the shutdown of the Connection to RabbtiMQ. That's why I expanded the
$rabbitmq_serverconfig withshutdown_hook_priority.Alternate Designs
Thought about setting the hook hard coded to
PHP_INT_MAXbut making it configurable is more flexible.Benefits
You have more finegrained control of when the Connection is destroyed.
Possible Drawbacks
Maybe a bit more complex, but default behavior is unchanged.
Verification Process
I implemented fork in my project and it worked.
Checklist:
Applicable Issues
Changelog Entry